#30752: Allow using ExceptionReporter subclass in
django.views.debug.technical_500_response
---------------------------------+---------------------------------------
     Reporter:  Carlton Gibson   |                    Owner:  Pavel Lysak
         Type:  New feature      |                   Status:  assigned
    Component:  Error reporting  |                  Version:  master
     Severity:  Normal           |               Resolution:
     Keywords:                   |             Triage Stage:  Accepted
    Has patch:  1                |      Needs documentation:  1
  Needs tests:  0                |  Patch needs improvement:  0
Easy pickings:  1                |                    UI/UX:  0
---------------------------------+---------------------------------------

Comment (by Pavel Lysak):

 HI, thank you for review.

 I added some more to the docs. Also considered what you mentioned in PR on
 github.

 Also i thought about deprecating `DEFAULT_EXCEPTION_REPORTER_FILTER`. I
 like that idea because it may be confusing to have these similar settings.
 I think it would not be a problem to use something like this if we only
 want to change filtering behavior.

 {{{
 #!python
 class ExceptionReporter:

     filter_class = SafeExceptionReporterFilter

     def __init__(self, request, exc_type, exc_value, tb, is_email=False):
         self.filter = self.filter_class(self.request)
         ...

 class CustomExceptionReporter(ExceptionReporter):

     filter_class = CustomExceptionReporterFilter
 }}}

 This will allow us to get rid of `DEFAULT_EXCEPTION_REPORTER_FILTER `

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30752#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.98105839b0689740a87c0bae9db79aaf%40djangoproject.com.

Reply via email to