#30766: Make it easier to override custom ExceptionReporter subclass functions.
-------------------------------------+-------------------------------------
Reporter: Nasir Hussain | Owner: (none)
Type: | Status: new
Cleanup/optimization |
Component: Error reporting | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Nasir Hussain):
* has_patch: 0 => 1
Old description:
> Since now we are allowing to use custom ExceptionRepoter subclass in
> #29714. We should refactor ExceptionReporter and move
> [https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L319
> cookies] extraction to a function like we are doing for POST
> [https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L305
> here] so that It is easy to override sensitive cookies filtering in the
> custom subclass of ExceptionRepoter.
New description:
Since now we are allowing to use custom ExceptionRepoter subclass in
#29714. We should refactor ExceptionReporter and move
[https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L319
cookies] extraction to a function like we are doing for POST
[https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L305
here] so that It is easy to override sensitive cookies filtering in the
custom subclass of ExceptionRepoter.
[https://github.com/django/django/pull/11748 Patch], I could add unit
tests if required.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/30766#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/069.b720076ded0e4921bfe777cb2b1a164d%40djangoproject.com.
