#30500: Error reporting returns a circular import error on a python formatting
error, and does not restart the development server
-------------------------------------+-------------------------------------
Reporter: Runner15 | Owner: Tom
Type: | Forbes
Cleanup/optimization | Status: assigned
Component: Error reporting | Version: master
Severity: Normal | Resolution:
Keywords: error reporting, | Triage Stage: Accepted
error, circular import |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tom Forbes):
It was apparently fixed in 3.6.3 via this ticket:
https://bugs.python.org/issue31070 - "Fix a race condition in importlib
_get_module_lock()." and in this MR:
https://github.com/python/cpython/pull/3033/files
I'd like to fix it in master for a couple of reasons:
1. It adds no overhead at all and ensures this won't happen if there is a
regression in upstream Python. What if future importlib changes cause
this, or something similar to flair up again? - Note that the bug was
only _noticed_ due to some test changes, this doesn't give me a lot of
hope.
2. The only source of contention while starting the autoreloader is
importing the urlconf module, relying on unspecified, and until recently
buggy, thread safety in `importlib` isn't great. I'd like to be explicit
here.
But, then again, this specific issue is fixed in 3.6.3+, so maybe it's not
worth it.
--
Ticket URL: <https://code.djangoproject.com/ticket/30500#comment:17>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.8287b8ad8286c496532bdd9909df5656%40djangoproject.com.
