#30669: Can FILE_UPLOAD_MAX_MEMORY_SIZE be set to None?
-------------------------------------+-------------------------------------
               Reporter:             |          Owner:  nobody
  LincolnPuzey                       |
                   Type:  Bug        |         Status:  new
              Component:  File       |        Version:  master
  uploads/storage                    |       Keywords:
               Severity:  Normal     |  FILE_UPLOAD_MAX_MEMORY_SIZE, None,
           Triage Stage:             |  settings
  Unreviewed                         |      Has patch:  0
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  0
                  UI/UX:  0          |
-------------------------------------+-------------------------------------
 The settings reference for
 [https://docs.djangoproject.com/en/dev/ref/settings/#std:setting-
 FILE_UPLOAD_MAX_MEMORY_SIZE FILE_UPLOAD_MAX_MEMORY_SIZE] doesn't say
 anything about if this setting can be set to `None`.

 The first usages of it in
 
[https://github.com/django/django/blob/7f19e3713598a37b0809b5434114140170d12e34/django/core/handlers/asgi.py#L180
 asgi.py] does a `is None` check on it, suggesting it can be `None`.

 But the second usage of it in
 
[https://github.com/django/django/blob/b9cf764be62e77b4777b3a75ec256f6209a57671/django/core/files/uploadhandler.py#L163
 uploadhandler.py] does a `<=` comparison which raises a `TypeError` when
 it is `None`, suggesting it shouldn't be `None`

 I would be happy to submit a patch if someone with more knowledge of
 Django can answer the question.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30669>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/055.8199a042c9fa7cea3d4d497b0cae8519%40djangoproject.com.

Reply via email to