#30509: Various FileResponse fixes and changes
--------------------------------------+------------------------------------
     Reporter:  Piotr Kunicki         |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  HTTP handling         |                  Version:  master
     Severity:  Normal                |               Resolution:
     Keywords:  FileResponse          |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


Comment:

 Hi Piotr.

 Thank you for the follow-up and the PR. The test cases look correct, so
 lets accept this.

 For interest, how do some of these cases come up in the wild?

 1. When would you have a buffer passing an ''absolute'' value for
 `filename`?
 2. Equally, when would you have a buffer with an ''absolute'' `name`,
 either pointing to an existing file or not, that wasn't e.g. a named pipe
 itself?

 My imagination is lacking slightly just now as to how you'd hit these
 issues. :)

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30509#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.bf49c35ebdc9289a4778d2d22c8f9594%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to