#30499: PasswordResetView should be allowed to set `domain_override`.
-------------------------------------+-------------------------------------
     Reporter:  Mattia Procopio      |                    Owner:  Mattia
                                     |  Procopio
         Type:  New feature          |                   Status:  closed
    Component:  Uncategorized        |                  Version:  master
     Severity:  Normal               |               Resolution:  invalid
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by felixxm):

 * status:  assigned => closed
 * resolution:   => invalid


Comment:

 Mattia, Thanks for your work and sorry, but `domain` can be override
 easily with the current implementation, e.g.
 {{{
 views.PasswordResetView.as_view(extra_email_context={'domain':
 'custom.example.com'}).
 }}}

 I think that providing an extra `kwargs` for that is pointless.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30499#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.f1e3bd4c2e9c5922001c35c6c8011b83%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to