#30444: Refactor `BaseDatabaseSchemaEditor.create_model`
-------------------------------------+-------------------------------------
Reporter: Rob | Owner: nobody
Golding |
Type: | Status: new
Cleanup/optimization |
Component: Database | Version: master
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
I've been working on a project that uses Citus as the database (which is a
Postgres database extension). I found it easy to override methods to
change most of the behaviour in the `BaseDatabaseSchemaEditor` class, but
the `create_model` functionality differs in that it directly executes SQL
which it generates itself.
I propose extracting this logic into a `table_sql` method, similar to how
`column_sql` works.
I'm happy to submit a PR for this work if it sounds like a reasonable
improvement!
--
Ticket URL: <https://code.djangoproject.com/ticket/30444>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/053.0d4e166f35362c2547eee732802dda65%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
