#30359: Possible access to unintended variable in
"django/tests/contenttypes_tests/test_models.py" line 128
-----------------------------------------+------------------------
               Reporter:  petrufm        |          Owner:  nobody
                   Type:  Bug            |         Status:  new
              Component:  Uncategorized  |        Version:  master
               Severity:  Normal         |       Keywords:
           Triage Stage:  Unreviewed     |      Has patch:  0
    Needs documentation:  0              |    Needs tests:  0
Patch needs improvement:  0              |  Easy pickings:  0
                  UI/UX:  0              |
-----------------------------------------+------------------------
 While experimenting with a CodeSonar plugin we develop, we noticed a
 potential bug in file "django/tests/contenttypes_tests/test_models.py"
 line 128 function test_get_for_concrete_model.

 self.assertEqual(concrete_model_ct,
 ContentType.objects.get_for_model(DeferredProxyModel)) <<<<<<HERE
 self.assertEqual(
             proxy_model_ct,
             ContentType.objects.get_for_model(DeferredProxyModel,
 for_concrete_model=False)

 Shouldn't you use proxy_model_ct instead of concrete_model_ct in the first
 line (as it is used in the second)?

 Thanks,
 Petru-Florin Mihancea

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30359>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.cc62c2d11107785561431ae6af955210%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to