#30302: forms.models.model_to_dict fails when `fields` is empty list
--------------------------------------+------------------------
Reporter: Belegnar | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 2.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------+------------------------
Been called as `model_to_dict(instance, fields=[])` function should return
empty dict, because no fields were requested. But it returns all fields
The problem point is
`if fields and f.name not in fields:`
which should be
`if fields is not None and f.name not in fields:`
PR: https://github.com/django/django/pull/11150/files
--
Ticket URL: <https://code.djangoproject.com/ticket/30302>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/051.bfd3ad880c391ab4660d7eaff1d76e40%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
