#30153: ModelAdmin with custom widgets, inlines, and filter_horizontal can merge
media in broken order
-------------------------------+------------------------------------
Reporter: roybi | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Comment (by Johannes Hoppe):
Hi there, I was the one introducing the warning. The warning is emitted
when the defined asset order can not be maintained. Which is a good thing
to warn about, but not always a problem. It is particularly not an issue,
if you have nested forms, where assets from multiple fields are merged
into preliminary forms (like inlines) just to be merged again.
I think a real solution could be to retain information about the
explicitly defined order-constraints and ignore the implicit once. The
merging algorithm can stay as is, it is correct. All that would need to be
done, is order violation violates an implicit or explicit asset order
before emitting the warning.
This would however use a bit more memory, since we would need to keep a
record of constraints (list of tuples).
What do you think? I could invest a bit of time, to draft a solution.
--
Ticket URL: <https://code.djangoproject.com/ticket/30153#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.1ac6487014f5548e09e9984785f1367a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
