#28687: Add a 'Not Empty' option to admin's related filter
-------------------------------------+-------------------------------------
Reporter: Brillgen Developers | Owner: Jake
Type: | Barber
Cleanup/optimization | Status: closed
Component: contrib.admin | Version: 2.0
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sardorbek Imomaliev):
Hi Carlton,
Thanks for reply, it is not broken because there is no `Not Empty` choice
in django itself
created new issue https://code.djangoproject.com/ticket/30149
Replying to [comment:11 Carlton Gibson]:
> Hi Sardorbek.
>
> This looks like a (related but) separate issue. Can you submit a new
ticket, something along the lines of "Empty value `selected` check in
Admin Filter prevents subclassing" and we can have a look.
>
> At first glance I can't see how both `bool(self.lookup_val_isnull)` and
`self.lookup_val_isnull == 'False'` evaluate as `True` in the `Not Empty`
case. (???) Surely the existing `empty_choice` logic would already be
broken if they did.
>
> If you have a PR (with a test case showing the broken example) available
(or can provide one when opening the ticket) it makes it much easier to
assess.
>
> Thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/28687#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.a2339a1996e00097868c5486aa5b797f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
