#30095: System check error for tuples in model field choices
-------------------------------------+-------------------------------------
Reporter: Pedro Marcondes | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 2.1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: choices tuple | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* severity: Release blocker => Normal
Comment:
OK, lets downgrade this to `Normal`: the change in behaviour of the
**system check** isn't quite a change in behaviour of the code itself.
(The [https://docs.djangoproject.com/en/2.1/ref/settings/#silenced-system-
checks system check can always be silenced].)
* Implementing `RangeField._check_choices()` would be feasible.
* Maybe raising the `is_value()` helper to class level would allow
avoiding too much duplication.
* We may need to separate the `is_value()` logic from the
`is_human_readable_label()` test — currently the `is_value()` helper is
used for both tasks.
* Maybe a fix to #20749 addresses this too, but they don't seem quite the
same. (I could see a fix for this without the more general problem being
solved.)
--
Ticket URL: <https://code.djangoproject.com/ticket/30095#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/063.3b9d92de22c9de28736315dfed6e15b5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
