#29931: Remove untested ValueError catching in naturalday template filter
-------------------------------------+-------------------------------------
Reporter: Hasan Ramezani | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: assigned
Component: contrib.humanize | Version: 2.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):
* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted
Old description:
> Small change in `contrib.humanize.templatetags.humanize.naturalday` and
> test to cover `ValueError` in this function.
New description:
This branch is untested:
{{{
except ValueError:
# Date arguments out of range
}}}
I don't see how that branch could happen if `value` is a date.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/29931#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.8d5ca5ff84a098dee69613ddd83e38c6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
