#29069: Static file serving does not call request_finished signal
-------------------------------------+-------------------------------------
Reporter: André Cruz | Owner: nobody
Type: Bug | Status: new
Component: HTTP handling | Version: 1.11
Severity: Normal | Resolution:
Keywords: streamingresponse | Triage Stage: Accepted
request_finished |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tom Forbes):
On the PR Tim suggested:
> Maybe it's possible to makes sense to omit the request_started signal
for static files (if possible)?
I do not believe it is, not without breaking a lot of our lovely
abstractions. We could maybe fix it hackily for *just* for `staticfiles`,
but the problem persists for *any* arbitrary `FileResponse`
One potential thing I thought of is to wrap the `'wsgi.file_wrapper'` in a
custom wrapper, which then calls `close()` on the request. But the
problems would be similar to solution #1 above, and it would break any
`isinstance()` checks that wsgi servers may perform.
All in all I'm a bit stumped. This seems to be a deficiency with the wsgi
spec more than anything
--
Ticket URL: <https://code.djangoproject.com/ticket/29069#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.1244060fa8ea76a9b0c405b2697e894e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
