#29640: Document (deprecate?) Paginator._get_page
--------------------------------------+------------------------------------
Reporter: Josh Schneier | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: 2.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Carlton Gibson):
* stage: Unreviewed => Accepted
Comment:
Moving to `get_page_class()` plus `page_class` seems reasonable.
* I know it's not ''public'' but maybe we should deprecate `_get_page()`,
since it's been around a while. (Tim?)
* If so, there's a slight wiggle: `_get_page()` returns the instance where
`get_page_class()` would presumably give us the class, which we then
instantiate in `page()`.
Not sure whether just having the attribute would be enough? Maybe someone
is customising for first or last page, as one thought. We may as well
leave it available (rather than needing to re-add it later.)
--
Ticket URL: <https://code.djangoproject.com/ticket/29640#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.9b8601766dd8526621f9a4897cf48903%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
