#29563: SQLite and Queryset.iterator() support
-------------------------------------+-------------------------------------
Reporter: Andrew Brown | Owner: Andrew
| Brown
Type: Uncategorized | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Simon Charette):
Hey Andrew, first thanks for the extremely well detailed report,
investigation, and the initial patch.
The only change I'd make to your branch is to break it in two commits.
A first one that addresses the `execute_sql()` `and`->`or` switch and adds
a test to make sure the result is fully iterated when `(chunked_fetch :=
True) and (connection.features.can_use_chunked_reads := False)`. I'm not
sure exactly where the test should live and how the testing should be
performed but you could rely on
`@skipIfDatabaseFeature('can_use_chunked_reads')` to skip the test on
backends that don't support it. I'd start with this commit while having
the feature turned off on SQLite to make the iteration easier. I'd also
refer the commit that added support for this feature in the commit
message.
Then I'd include the rest of the changes in a second commit referring to
this ticket.
By the way, you can open a PR with your branch to give it more exposure
and have it run against CI.
--
Ticket URL: <https://code.djangoproject.com/ticket/29563#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.48201ca01b1ba2427405b3388d8af6f8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
