#29525: Handle strings as allowed_hosts arguments to is_safe_url()
--------------------------------------+------------------------------------
Reporter: Przemysław Suliga | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Jon Dufresne):
Type checking is fine by me and helps avoid a potentially unsafe mistake.
+1
Whether that type checking results in coercing (as done in the PR) or
raises an exception, I have no strong opinion. Either is sufficient to
prevent mistakes. I guess an exception is a bit more explicit, but, again,
no strong opinion.
--
Ticket URL: <https://code.djangoproject.com/ticket/29525#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.22ea1ffa4818975c95b560b5e0166750%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
