#29415: custom url converters are not picked up on reverse when part of included
patterns
-----------------------------+--------------------------------------
     Reporter:  Xaroth       |                    Owner:  nobody
         Type:  Bug          |                   Status:  new
    Component:  Core (URLs)  |                  Version:  master
     Severity:  Normal       |               Resolution:
     Keywords:               |             Triage Stage:  Unreviewed
    Has patch:  1            |      Needs documentation:  0
  Needs tests:  0            |  Patch needs improvement:  0
Easy pickings:  0            |                    UI/UX:  0
-----------------------------+--------------------------------------
Changes (by Xaroth):

 * has_patch:  0 => 1


Comment:

 Added a patch in the form of a pull request:
 https://github.com/django/django/pull/9965

 Main changes made:
 - Push converters from parent sections onto namespace url resolvers when
 reverse()'ing
 - Add converters from the base url pattern to sub-urls for included
 urlpatterns
 - Add tests for reversing custom url converters

 I am not entirely sure on the cleanliness of the method used, so it might
 need reviewing.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29415#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.2ad9e5c3c3d3ad1131a7cbd524ed209d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to