#29244: Paginator.count() may incorrectly silence AttributeError and TypeError
--------------------------------------+------------------------------------
Reporter: Rob Jauquet | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: 2.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham):
* type: Bug => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
It looks like the best solution would be to remove the try/except in
`Paginator.count()`. `AttributeError` can be removed with
`hasattr(self.object_list, 'count')` and `TypeError` with some checking
that count is a method without any arguments. Perhaps a new function in
`django/utils/inspect.py` would help with that.
--
Ticket URL: <https://code.djangoproject.com/ticket/29244#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.2f4564ae4c798e8cf7244c4ebc3f1a87%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
