#27654: Propogate alters_data value to subclasses
--------------------------------------+------------------------------------
Reporter: vinay karanam | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Core (Other) | Version: master
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Carlton Gibson):
* status: new => closed
* resolution: => wontfix
Comment:
After looking at the implementation on the PR, the proposed metaclass
solution is too much to given the relatively small improvement over the
current `alters_data` solution.
The remaining suggestion from #27638 was to use the system checks
framework to warn users of a problem. That might be worth a go. It would
be able to capture the most common cases on `Model` classes certainly.
(Whether we want to add that isn't clear: in lots of cases `save` is
overridden without setting `alters_data` — to make that an error might be
more annoying than a benefit, but it could at least be silenced.)
--
Ticket URL: <https://code.djangoproject.com/ticket/27654#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/072.5a3ddd055ca93949204135d8433ebed9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
