#21963: makemessages still ignores translations in templates with inline comment
tags
-------------------------------------+-------------------------------------
     Reporter:  Ihor Kaharlichenko   |                    Owner:  Sergey
  <madkinder@…>                      |  Kolosov
         Type:  Bug                  |                   Status:  assigned
    Component:                       |                  Version:  1.6
  Internationalization               |
     Severity:  Normal               |               Resolution:
     Keywords:  makemessages,        |             Triage Stage:  Accepted
  template, gettext, xgettext        |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1


Comment:

 Current patch simply reverts a number of changes from #19552. Including
 adding warnings (i.e. it removes them again), which seems a loss.
 It reverses the logic of a number of test cases, going against decisions
 made in #19552.

 I've suggested on the ticket that we try and reach a consensus on the
 mailing list on the correct behaviour for each type of case. From there a
 resolution (without just reverting the previous work) should be easier.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/21963#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/098.ca2d94b8c6413f2a9c0abeea9a22a142%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to