#29113: django.forms.formsets.all_valid() short circuit
--------------------------------------+------------------------------------
     Reporter:  Дилян Палаузов        |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  Forms                 |                  Version:  master
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by Tim Graham):

 * has_patch:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Short-circuiting isn't valid because all formsets must be validated. I
 added a test for that in 4bcec02368b7e5466f64dc17286689b16613c94b.

 [https://github.com/django/django/pull/9663 PR] to clarify the docstring
 and make the simplification.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29113#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.a93689ff63b8d3c841065d0613578d7e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to