#28638: Allow `is_safe_url` to work without `allowed_hosts` or make the
parameter
mandatory
-------------------------------------+-------------------------------------
Reporter: kemar | Owner: Piotr
Type: | Domański
Cleanup/optimization | Status: assigned
Component: Utilities | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Jon Dufresne):
> I'm not sure if there's a use case for not providing it.
I'm also unsure what the use case if for using `is_safe_url` without an
`allowed_hosts` argument. To anyone that is asking for this feature, can
you provide details on your use case that would make it clear why this is
a good idea?
When I added `allowed_hosts` it was originally optional because, at the
time, the user could pass either `allowed_hosts` or `hosts`. Now that
there is only `allowed_hosts`, I think it should be a required argument
(unless a use case surfaces).
--
Ticket URL: <https://code.djangoproject.com/ticket/28638#comment:14>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/063.8ae3b98c1c8c891c9790c8dff90a95cb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
