#28893: Narrow dict.items() calls to .keys()/.items()
--------------------------------------+------------------------------------
Reporter: Дилян Палаузов | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham):
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
* component: Uncategorized => Core (Other)
* stage: Unreviewed => Accepted
Comment:
`keys()` is generally unneeded. Something like `for name in
tb_frame.f_locals` does an implicit keys; see
21046e77734278cea871dce922220bf29aa5b7b4. I guess you didn't test the
patch as there's at least one mistake in `debug.py` that broke things.
By the way, is there something preventing you from submitting patches on
GitHub? If it's only the knowledge of how to to do, we have
[https://docs.djangoproject.com/en/dev/intro/contributing/#committing-the-
changes-in-the-patch a tutorial].
--
Ticket URL: <https://code.djangoproject.com/ticket/28893#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/072.ee4c33db37af8eefee1291fe0a9addf2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
