#28823: Nested @override_settings on class and method do not work correctly
-------------------------------+--------------------------------------
     Reporter:  Paolo D'Apice  |                    Owner:  (none)
         Type:  Bug            |                   Status:  closed
    Component:  Uncategorized  |                  Version:  1.10
     Severity:  Normal         |               Resolution:  wontfix
     Keywords:                 |             Triage Stage:  Unreviewed
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+--------------------------------------
Changes (by Simon Charette):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 I agree with Piotr's reasoning. We aren't deep copying mutable settings on
 override and I don't think we should be.

 If you want to alter mutable settings I'd suggest you override the setting
 itself in the context of your alteration. In your case that would be using
 decorating your `test_delete_foo` method with
 `override_settings(**deepcopy(TEST_SETTINGS))`.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/28823#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.5c063f627f790efef373b8ae0cee1869%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to