#28754: validate_ipv46_address validator allows IP addresses to begin with a
first
octet of zero
-------------------------------------+-------------------------------------
Reporter: frankston | Owner: Tim G.
Type: Bug | Status: assigned
Component: Core (Other) | Version: 1.11
Severity: Normal | Resolution:
Keywords: IP, regular | Triage Stage:
expression | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):
* has_patch: 0 => 1
Comment:
Specifically, my concern is that the proposed regular expression is much
more complicated and less readable. Part of that concern is because we've
had security issues due to complicated regular expressions that are
vulnerable to catastrophic backtracking.
Tim, pull requests should go to the master branch rather than a stable
branch. The committer will take care of backporting if needed, but this
fix doesn't qualify for a backport to 1.11 based on our
[https://docs.djangoproject.com/en/dev/internals/release-process
/#supported-versions supported versions policy]. Don't forget to check
"Has patch" on the ticket so that it appears in the review queue.
Generally, you may not want to work on a ticket until it's "Triage Stage"
is moved to "Accepted" to indicate a consensus to make a change (although
seeing a patch for this is helpful in determining if the additional
complexity is worthwhile).
--
Ticket URL: <https://code.djangoproject.com/ticket/28754#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.496e332d19c654ecd747620eff7e28cc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
