#28555: Inconsistent empty value for EmailField(blank=True, null=True) due to 
strip
after check for empty value
-----------------------------+-----------------------------------------
     Reporter:  Olav Morken  |                    Owner:  Josh Schneier
         Type:  Bug          |                   Status:  assigned
    Component:  Forms        |                  Version:  master
     Severity:  Normal       |               Resolution:
     Keywords:               |             Triage Stage:  Accepted
    Has patch:  1            |      Needs documentation:  0
  Needs tests:  0            |  Patch needs improvement:  0
Easy pickings:  0            |                    UI/UX:  0
-----------------------------+-----------------------------------------

Comment (by Josh Schneier):

 Replying to [comment:3 Tim Martin]:
 > The change looks good to me, but it should be squashed into a single
 commit.

 In this case I intentionally did not rebase down because of the additional
 fix/patch I added. I'm not sure if it's necessary and wanted to leave the
 history for the reviewer to help with that determination.

 Thanks for the review!

-- 
Ticket URL: <https://code.djangoproject.com/ticket/28555#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.16f47bae010945ba5577a5687ad2b4c9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to