#28451: Change in Oracle sequence name truncation causes regression when
updating
existing database
-------------------------------------+-------------------------------------
Reporter: Kevin Grinberg | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 1.11
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Shai Berger):
* cc: Shai Berger (added)
Comment:
I concur. Note that the change makes the names shorter than necessary --
the idea behind using `self.max_name_length() - 3` is to save space for
the `_SQ` suffix, but the change now includes that suffix in the truncated
text.
I also think we should similarly revert the analogous change in trigger
name truncation. I'm not sure we ever use calculated trigger names after
the trigger is created, however,
* if we do, then the same considerations as with sequences apply
* if we don't, then it's better to have consistent code and use the full
available name length
--
Ticket URL: <https://code.djangoproject.com/ticket/28451#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.612e1de08778e9a32014eb3e6e1c3d86%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
