#27928: Gratuitous ALTER COLUMN statements generated for adding blank=True
-----------------------------------+------------------------------------
Reporter: Christophe Pettus | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by Tim Graham):
* stage: Unreviewed => Accepted
Comment:
Looks like an issue with
[https://github.com/django/django/blob/75503a823f6358892fff5aeb3691683ad9cc5a60/django/db/backends/base/schema.py#L191-L217
SchemaEditor.effective_default()]. It returns `None` for the old field and
`''` (empty string) for the new field, thus the
[https://github.com/django/django/blob/75503a823f6358892fff5aeb3691683ad9cc5a60/django/db/backends/base/schema.py#L578-L584
needs_database_default] condition is True. Probably `effective_default()`
should return an empty string for the old field.
--
Ticket URL: <https://code.djangoproject.com/ticket/27928#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/061.59144071df01473f6658f2048d4a85a3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
