#27735: l10n change for Select widget
-----------------------------------------+------------------------
Reporter: David Szotten | Owner: nobody
Type: Uncategorized | Status: new
Component: Forms | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
While trying to update django-crispy-forms to django master (1.11) i came
across the following:
on 1.10,
Select (and e.g. RadioSelect, CheckboxSelectMultiple) don't seem to
localise labels, but with template based widget rendering they do
(compare the output before and after template based widget rendering (e.g.
1.10 vs current master)
{{{
settings.USE_L10N = True
settings.USE_THOUSAND_SEPARATOR = True
print forms.RadioSelect(choices=[(1000, 1000)]).render('foo', '1000')
# master
<option value="1000" selected>1,000</option>
# 1.10
<option value="1000" selected="selected">1000</option>
}}}
I've not been able to find documentation (my search-fu might be failing
me) about either behaviour, (nor am i a user of l10n so i'm not sure which
of these behaviours is more "correct")
so my question is: is this a regression? a bugfix?
(in https://github.com/django-crispy-forms/django-crispy-
forms/issues/214#issuecomment-21688123 django-crispy-forms seems to choose
its behaviour to match django, and adds explicit tests for the old
behaviour)
Thanks
--
Ticket URL: <https://code.djangoproject.com/ticket/27735>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/055.29637bcefba98f7c3eae6090c19a7cc4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
