#27626: Remove unnecessary setattr code path in settings
-------------------------------------+-------------------------------------
Reporter: Adam | Owner: Adam Chainz
Chainz |
Type: | Status: assigned
Cleanup/optimization |
Component: Core | Version: 1.10
(Other) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
`BaseSettings` has a `__setattr__` method just to check that `MEDIA_URL`
and `STATIC_URL` don't end with a slash. I think these would be better off
as system checks, which would avoid the overhead on every single change of
settings. The code pre-dates checks by a few years which would explain why
it was done like that.
--
Ticket URL: <https://code.djangoproject.com/ticket/27626>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/053.a5c000fc9083765940cd016d6f53a689%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
