#27596: LiveServerTestCase in 1.10.4 doesnt close server ports properly
-----------------------------------+--------------------------------------
Reporter: Mike Hibbert | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Comment (by Mike Hibbert):
Replying to [comment:5 Tim Graham]:
> Can you follow the bisect procedure that I linked? Your report doesn't
contain enough details to explain why Django is at fault. It looks like
[https://github.com/gabrielfalcao/lettuce lettuce] isn't tested with
Django 1.10 yet.
I'm not able to bisect it as I've checked the Django fork I made and I
don't know enough about testing a test framework component enough to make
it match the actual test case I've supplied.
I've narrowed it down to the fact that django.testcases.LiveServerTestCase
implements the server creation and shutdown processes differently which is
a breadcrumb.
My reason for suspecting Django to be at fault is that the lines of code
that start the LiveServerTestCase from lettuce are the same and work for
all previous versions of Django.
Also, lettuce does not implement any test server threading or port
handling which is leveraged from Django so I'm pretty sure Django is the
issue here unless there are some new considerations in the release notes
that I haven't seen? I'm pretty sure the use case for LiveServerTestCase
is as follows:
LiveServerTestCase.setUpClass()
# do some stuff then latter ..
LiveServerTestCase.tearDownClass()
This is correct isn't it?
.
--
Ticket URL: <https://code.djangoproject.com/ticket/27596#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/069.23ac3c981d8daa1d2217f9bae63078cd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
