#27594: Reverse one to one related object populated from incorrect query columns
-------------------------------------+-------------------------------------
     Reporter:  Daniel Hillier       |                    Owner:  Daniel
                                     |  Hillier
         Type:  Bug                  |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:  onetoone reverse     |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Daniel Hillier):

 * needs_better_patch:  1 => 0


Comment:

 Thanks for the review!

 I've simplified the way I fixed the bug and implemented your suggestions.

 I think the heart of the bug was the definition of `from_parent`. A
 relationship between two models isn't `from_parent` if the two model
 classes are the same. I've updated how `from_parent` is defined to reflect
 that corner case.

 Happy to incorporate any further changes you may have.

--
Ticket URL: <https://code.djangoproject.com/ticket/27594#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c864729817df5d5098acee89c04c1f34%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to