#27564: `refresh_from_db()` should return the model instance instead of None
-------------------------------------+-------------------------------------
Reporter: Tom | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):
* component: Uncategorized => Database layer (models, ORM)
Comment:
I'm not sure. I thought it might have been discussed before, but if so, I
can't find it. `Model.save()` doesn't return `self` either which seems
like a similar situation. Can you think of anywhere else in Django (or
Python) where this pattern is used?
Considerations:
- Anyone overriding the method may have to add a return value to adapt
their code for the new convention.
- For new users, it may make it unclear whether or not the `obj` on which
the `refresh_from_db()` is called is updated, or if it's required to do
`obj = obj.refresh_from_db()`.
--
Ticket URL: <https://code.djangoproject.com/ticket/27564#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/061.b9e47578cb8cfe49763759c8552a4583%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
