#27518: HTTP Referer leaks password reset link
----------------------------------+--------------------------------------
     Reporter:  Romain Garrigues  |                    Owner:  nobody
         Type:  New feature       |                   Status:  new
    Component:  contrib.auth      |                  Version:  1.10
     Severity:  Normal            |               Resolution:
     Keywords:  password reset    |             Triage Stage:  Unreviewed
    Has patch:  0                 |      Needs documentation:  0
  Needs tests:  0                 |  Patch needs improvement:  0
Easy pickings:  0                 |                    UI/UX:  0
----------------------------------+--------------------------------------

Comment (by Romain Garrigues):

 I gave a first try to the approach described in the article.
 I kept the password_reset_confirm interface, and redirects to a
 password_reset_confirm_secure view.
 I didn't know how to keep the original params from the view other than
 saving them in the session (redirect can't receive them in the keyword
 args, as they are used in a reverse url call).
 This solution has 2 main issues:
 - Saving params in the session seems a bit hacky, and not everything is
 serialisable,
 - While it keeps backward-compatibility if people are using
 django.contrib.auth.urls, it won't work if you don't include these urls
 but have custom ones. It them means that you will have to define a new url
 for django_reset_confirm_secure view...

--
Ticket URL: <https://code.djangoproject.com/ticket/27518#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.9cdd9bf1a4b555e836634618aa249395%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to