#27309: Missing Hash function in CallableBool
--------------------------------+--------------------------------------
     Reporter:  Reto Aebersold  |                    Owner:  nobody
         Type:  Bug             |                   Status:  new
    Component:  Utilities       |                  Version:  1.10
     Severity:  Normal          |               Resolution:
     Keywords:                  |             Triage Stage:  Unreviewed
    Has patch:  0               |      Needs documentation:  0
  Needs tests:  0               |  Patch needs improvement:  0
Easy pickings:  0               |                    UI/UX:  0
--------------------------------+--------------------------------------
Changes (by Reto Aebersold):

 * needs_better_patch:   => 0
 * component:  Uncategorized => Utilities
 * needs_tests:   => 0
 * needs_docs:   => 0
 * type:  Uncategorized => Bug


Old description:

> As
> [https://github.com/django/django/blob/b7fb608142a0be568bc5dce952de5e6aefc2488c/django/utils/deprecation.py#L87
> CallableBool] has no hash function, membership test operations for sets
> do not work:
>
> {{{
> from django.utils.deprecation import CallableTrue
> assert CallableTrue in {True}
>
> TypeError: unhashable type: 'CallableBool'
> }}}
>
> Adding a hash function solves this problem:
>
> {{{
> def __hash__(self):
>     return hash(self.value)
> }}}
>
> I'm happy to create a PR if this make sense.

New description:

 As
 
[https://github.com/django/django/blob/b7fb608142a0be568bc5dce952de5e6aefc2488c/django/utils/deprecation.py#L87
 CallableBool] has no hash function, membership test operations for sets do
 not work:

 {{{
 from django.utils.deprecation import CallableTrue
 assert CallableTrue in {True}

 TypeError: unhashable type: 'CallableBool'
 }}}

 Adding a hash function solves this problem:

 {{{
 def __hash__(self):
     return hash(self.value)
 }}}

--

--
Ticket URL: <https://code.djangoproject.com/ticket/27309#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.c3db3647e51097291f220be84b2ff2d6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to