#26447: Deprecate USE_ETAGS setting in favor of ConditionalGetMiddleware
unconditionally setting an ETag
--------------------------------------+------------------------------------
Reporter: syphar | Owner: syphar
Type: Cleanup/optimization | Status: new
Component: HTTP handling | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):
* needs_better_patch: 1 => 0
Old description:
> (with deprecation)
>
> In my opinion this setting is not needed (any more)
>
> - Conditional-Get handling can happen in the ConditionalGetMiddleware,
> not in CommonMiddleware any more
> - using or not using the middleware is (nearly) the same as setting
> USE_ETAGS or not
> - ETag Calculation can happen also in the middleware
>
> this also will fix a problem when you use the GZipMiddleware in
> combination with the Conditional-Get handling in CommonMiddleware.
>
>
> Open questions for me:
> - ConditionalGetMiddleware also handles Last-Modified/If-Modified-Since ,
> which CommonMiddleware didn't. I don't see a problem in throwing them
> together and activating/deactivating them together. You?
New description:
In my opinion this setting is not needed (any more)
- Conditional-Get handling can happen in the ConditionalGetMiddleware, not
in CommonMiddleware any more
- using or not using the middleware is (nearly) the same as setting
USE_ETAGS or not
- ETag Calculation can happen also in the middleware
this also will fix a problem when you use the GZipMiddleware in
combination with the Conditional-Get handling in CommonMiddleware.
Open questions for me:
- ConditionalGetMiddleware also handles Last-Modified/If-Modified-Since ,
which CommonMiddleware didn't. I don't see a problem in throwing them
together and activating/deactivating them together. You?
--
Comment:
[https://github.com/django/django/pull/7256 Updated PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/26447#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.2130eaf3b31c072c0a3f59537c927dbf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
