#27081: Allow migrations to serialize methods on pypy
----------------------------+------------------------------------
Reporter: Kurdakov | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------+------------------------------------
Changes (by timgraham):
* type: Uncategorized => Bug
* has_patch: 0 => 1
* stage: Unreviewed => Accepted
* component: Uncategorized => Migrations
Comment:
Seems okay. That proposed change fixes these existing test failures on
pypy, so I guess no new tests are needed:
{{{
======================================================================
ERROR: test_serialize_datetime (migrations.test_writer.WriterTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/tim/code/django/tests/migrations/test_writer.py", line 330,
in test_serialize_datetime
self.assertSerializedEqual(datetime.datetime.utcnow)
File "/home/tim/code/django/tests/migrations/test_writer.py", line 194,
in assertSerializedEqual
self.assertEqual(self.serialize_round_trip(value), value)
File "/home/tim/code/django/tests/migrations/test_writer.py", line 190,
in serialize_round_trip
string, imports = MigrationWriter.serialize(value)
File "/home/tim/code/django/django/db/migrations/writer.py", line 293,
in serialize
return serializer_factory(value).serialize()
File "/home/tim/code/django/django/db/migrations/serializer.py", line
388, in serializer_factory
"topics/migrations/#migration-serializing" % (value,
get_docs_version())
ValueError: Cannot serialize: <bound method type.utcnow of <class
'datetime.datetime'>>
There are some values Django cannot serialize into migration files.
For more, see https://docs.djangoproject.com/en/dev/topics/migrations
/#migration-serializing
======================================================================
ERROR: test_simple_migration (migrations.test_writer.WriterTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/tim/code/django/tests/migrations/test_writer.py", line 542,
in test_simple_migration
output = writer.as_string()
File "/home/tim/code/django/django/db/migrations/writer.py", line 163,
in as_string
operation_string, operation_imports =
OperationWriter(operation).serialize()
File "/home/tim/code/django/django/db/migrations/writer.py", line 120,
in serialize
_write(arg_name, arg_value)
File "/home/tim/code/django/django/db/migrations/writer.py", line 72, in
_write
arg_string, arg_imports = MigrationWriter.serialize(item)
File "/home/tim/code/django/django/db/migrations/writer.py", line 293,
in serialize
return serializer_factory(value).serialize()
File "/home/tim/code/django/django/db/migrations/serializer.py", line
43, in serialize
item_string, item_imports = serializer_factory(item).serialize()
File "/home/tim/code/django/django/db/migrations/serializer.py", line
228, in serialize
return self.serialize_deconstructed(path, args, kwargs)
File "/home/tim/code/django/django/db/migrations/serializer.py", line
100, in serialize_deconstructed
arg_string, arg_imports = serializer_factory(arg).serialize()
File "/home/tim/code/django/django/db/migrations/serializer.py", line
388, in serializer_factory
"topics/migrations/#migration-serializing" % (value,
get_docs_version())
ValueError: Cannot serialize: <bound method type.utcnow of <class
'datetime.datetime'>>
There are some values Django cannot serialize into migration files.
For more, see https://docs.djangoproject.com/en/dev/topics/migrations
/#migration-serializing
}}}
[https://github.com/django/django/pull/7113 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/27081#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.009d4214b5fbb5d8884e2f0d2fa50c2d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
