#27079: LiveServerPort.test_port_bind() sets allow_thread_sharing to False
before
all server threads are done
-------------------------------+--------------------
Reporter: cjerdonek | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
Currently, `LiveServerPort.test_port_bind()` calls
`LiveServerTestCase.setUpClass()` and `LiveServerTestCase.tearDownClass()`
''twice'' (to create two live server threads -- see
[https://github.com/django/django/blob/e76981b43325da60b8a7475661df6cbfa7fda37e/tests/servers/tests.py#L133
here] for the code). On the tear-down side, this has the unwanted side
effect of setting `conn.allow_thread_sharing` to False before all live
server threads are done with their connections.
The test should really only be calling the full `setUpClass()` and
`tearDownClass()` once (but still doing the partial setup and tear-down
that it needs for the purposes of its test).
--
Ticket URL: <https://code.djangoproject.com/ticket/27079>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/052.323999464a0efaab6693de340965ce74%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
