#26998: admin.E013 check false positive on django-taggit
-------------------------------+--------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by collinanderson):
* status: closed => new
* cc: cmawebsite@… (added)
* resolution: duplicate =>
Comment:
Hi All, Sorry I'm late to respond on this.
I encouraged the 983c158da7723eb00a376bd31db76709da4d0260 change in hopes
of being more liberal in what django _accepts_, but I see now that the
many cases the change made django more liberal in what it flags as a
problem.
Yes, #12203 is a good new behavior that would solve this problem, but I'd
consider the 983c158da7723eb00a376bd31db76709da4d0260 to be a regression,
because it breaks things that work fine in 1.9. (Though, yes, you could
argue, private APIs, etc.)
I think we should revert the entire checks.py file changes except for
admin.E003 and admin.E020. (I think the "must be m2m" checks should allow
all many_to_many, and the "can't be m2m" checks should only check
ManyToManyField.). That way django allows more custom fields.
(I'm re-opening so this comment doesn't get lost. Feel free to wontfix if
we don't want to revert the check.py changes.)
--
Ticket URL: <https://code.djangoproject.com/ticket/26998#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.48a6b6d7c25a69534d8c4479dba8ffa9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
