#27035: DiscoverRunner's setup_test_environment() hard-codes settings.DEBUG to
False
-------------------------------------+-------------------------------------
Reporter: cjerdonek | Owner: cjerdonek
Type: | Status: assigned
Cleanup/optimization |
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by cjerdonek):
Or are you suggesting that an argument be added to both
`DiscoverRunner.setup_test_environment()` ''and''
`DiscoverRunner.run_tests()`? That would be another way to address the
subclassing issue without needing to copy / reimplement methods.
See
[https://github.com/django/django/blob/a6baada7bdf0c2b14045ee86364f9401c7b91b7c/django/core/management/commands/test.py#L60
here] for how the test management command constructs the runner and
invokes `run_tests()`. As you can see, there are two options for passing
options: passing to the constructor and passing to `run_tests()`.
Currently, only the test labels are being passed to `run_tests()` and the
rest are passed via the constructor.
--
Ticket URL: <https://code.djangoproject.com/ticket/27035#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.bc01a8e0c85e78c38a5bb14f8d8a408e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
