#26841: Avoid remaking tables for altering index_together and unique_together in
sqlite3
-------------------------------------+-------------------------------------
Reporter: akki | Owner: akki
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):
* stage: Accepted => Ready for checkin
Comment:
I found that without sqlite3's
`DatabaseSchemaEditor.alter_unique_together()`
`schema.tests.SchemaTests.test_unique_together` failed on SQLite until
01ec127baec38b7f8281e6eca9def40f22c9e5ad.
I guess Markus copied the `override_uniques` pattern when he did a similar
thing for `override_indexes` in d2202ec2d4d0477b682c6d0051f27ab4843ef89f.
The test added in 03900a02d5fd2efd6ae98bdb9974b78146f63040 fails when
removing `override_uniques=...` in `sqlite3/schema.py` but starts passing
after e24e9e0438cf3ba6c557558f68587d135a85e126 so it seems okay to remove
that instance.
--
Ticket URL: <https://code.djangoproject.com/ticket/26841#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/062.f72b03d8f08909310f73acd90ab355fa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
