#25109: MigrationLoader.load_disk hides ImportError for invalid 
MIGRATION_MODULES
----------------------------+----------------------------------------
     Reporter:  blueyed     |                    Owner:  berkerpeksag
         Type:  Bug         |                   Status:  assigned
    Component:  Migrations  |                  Version:  master
     Severity:  Normal      |               Resolution:
     Keywords:              |             Triage Stage:  Accepted
    Has patch:  1           |      Needs documentation:  0
  Needs tests:  0           |  Patch needs improvement:  0
Easy pickings:  0           |                    UI/UX:  0
----------------------------+----------------------------------------

Comment (by charettes):

 What about letting the `ImportError` propagate if the invalid migration
 module is explicitly specified through `MIGRATION_MODULES` instead?

 I see the reasoning behind silencing it the default `app.migration`
 package is missing but if a module is explicitly specified I would expect
 an error to be raised just like any other setting.

 The `MigrationLoader.migrations_module` method's return type could be
 altered to be of the form `module_name, explicit` and the exception could
 be re-raised if `explicit` is truthy.

--
Ticket URL: <https://code.djangoproject.com/ticket/25109#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.766ecb8d985f70be6cc30e840a00e572%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to