#24227: isinstance checks on ForeignKey/ManyToManyField should be replaced with
field.many_to_one/field.many_to_many
-------------------------------------+-------------------------------------
     Reporter:  coldmind             |                    Owner:
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

 In [changeset:"f529d0cb5855db2dfc8d0d39850dbb4793bc75c2" f529d0cb]:
 {{{
 #!CommitTicketReference repository=""
 revision="f529d0cb5855db2dfc8d0d39850dbb4793bc75c2"
 [1.10.x] Refs #24227 -- Fixed crash of ManyToManyField.value_from_object()
 on unsaved model instances.

 This behavior was removed in 67d984413c9540074e4fe6aa033081a35cf192bc
 but is needed to prevent a crash in formtools.

 Backport of a4c20ae85b40c49e28d1b2227208e4f00d7820df from master
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24227#comment:24>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.224037c9eec98ddf32180e6ffccdd6f9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to