#26645: Errors when running i18n makemessages tests on Windows
-------------------------------------+-------------------------------------
Reporter: ramiro | Owner: ramiro
Type: Bug | Status: closed
Component: | Version: 1.10
Internationalization |
Severity: Normal | Resolution: fixed
Keywords: windows | Triage Stage: Ready for
makemessages | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Ramiro Morales <cramm0@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"6ab0d1358fc78077064aab88a4fb0a47ca116391" 6ab0d13]:
{{{
#!CommitTicketReference repository=""
revision="6ab0d1358fc78077064aab88a4fb0a47ca116391"
Fixed #26645 -- Fixed potential makemessages failures on Windows.
This was reflected by 27 i18n test errors (not failures) on such
platform caused by corrupt intermediate PO catalog files fed to
`msgmerge(1)`.
Made it handle in-memory PO/POT file contents with normalized line
separators (`'\n'`).
We need to perform manually this after using `subprocess.Popen` as we
can't pass it `universal_newlines=True`.
Also fixes #26670 in the process as this commit refactors the same code
section.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26645#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.f023a224494bc3a6c9af1e78ccef7237%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
