#25905: Unsafe usage of urljoin() within FileStorageSystem
--------------------------------------+------------------------------------
Reporter: free-Runner | Owner: rixx
Type: Cleanup/optimization | Status: closed
Component: File uploads/storage | Version: 1.9
Severity: Normal | Resolution: fixed
Keywords: file, storage | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Russell Keith-Magee <russell@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"fdf5cd3429369954e8deb764d9f30f6374581613" fdf5cd34]:
{{{
#!CommitTicketReference repository=""
revision="fdf5cd3429369954e8deb764d9f30f6374581613"
Fixed #25905 -- Prevented leading slashes in urljoin() calls
Leading slashes in the second urljoin argument will return exactly that
argument, breaking FileSystemStorage.url behavior if called with a
parameter with leading slashes.
Also added test cases for null bytes and None. Thanks to Markus for
help and review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25905#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/069.ce798beaf391fa2bbd7ca04559fffabb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
