#25759: Add **kwargs to as_sql method of Expressions
-------------------------------------+-------------------------------------
Reporter: jarshwah | Owner: shekhar-
| singh
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: expressions | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by jarshwah):
Some notes for completing this ticket:
Start by adding **kwargs to the method signature of as_sql for all
expression types, including transforms and lookups. There are quite a few
places.
For Func, get rid of the function and template key word arguments, and
merge self.extra with **kwargs in a local variable (so you don't modify
self.extra), using that to generate the sql string.
Need to update docs to reference the new **kwargs argument and change any
tests that override as_sql for vendor specific tests so that they no
longer modify self.template or self.function.
--
Ticket URL: <https://code.djangoproject.com/ticket/25759#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.1897098460833d8d06d0a440bb94ad5b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
