#26179: Remove null assignment check for non-nullable foreign key fields
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner:
Type: | ZachLiuGIS
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by ZachLiuGIS):
I have made the changes and created the pull request ticket_26179
I removed both value=None check in `ForwardManyToOneDescriptor` and
`ReverseOneToOneDescriptor`.
Because of that, several tests failed because they have assertRaise for
`ValueError`. So I removed those tests.
This is my first time working on Django. So please let me know if there's
anything I can do better:)
Thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/26179#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.04146979404d603bb2c4eaf942a525bb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
