#23155: Add request attr to user_login_failed signal
------------------------------+------------------------------------
Reporter: anonymous | Owner: nobody
Type: New feature | Status: new
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+------------------------------------
Comment (by gavinwahl):
One way I thought of to fix this is to add an optional `_request` kwarg to
django.contrib.auth.authenticate. If provided, it would be passed into the
call to user_login_failed. This would be backwards incompatible if anyone
were using an authentication backend that used `_request`, which seems
unlikely. Would a patch implementing this approach be accepted?
As it is user_login_failed isn't useful for what seems like its primary
purpose -- logging suspected attacks, which would need the IP address to
be useful at all.
--
Ticket URL: <https://code.djangoproject.com/ticket/23155#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.e62e2b1594feff32518cee15fe85ced7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
