#26175: Use create_user() managers in tests instead of hardcoding sha1 hashes
------------------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
In 39a7eed1bbf12020a077e4bec3d82e08f171a021, some test fixtures were
converted to use the ORM. This was a good step, but we still have
hardcoded sha1 hashes which aren't friendly to reverse if you actually
need the user's password.
Also, the fixtures were converted programmatically and some fields from
the fixtures aren't need in the ORM versions (such as `is_active=True`
since that's the default).
Most usage of `self.client.login(**credentials)` should be converted to
`self.client.force_login(user)`.
I attached a patch to get you started.
Please check the selenium tests too.
--
Ticket URL: <https://code.djangoproject.com/ticket/26175>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/052.b836da487edd6851f5fe6737c54ba882%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
